[Transform] disallow fieldnames with a dot at start and/or end #51369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 23, 2020 19:32
|
Pinging @elastic/ml-core (:ml/Transform) |
hendrikmuhs
changed the title
hendrikmuhs
pushed a commit
that referenced
this pull request
Jan 24, 2020
adds field validation to disallow output field names starting and/or ending with a '.'. Avoids indexing/mapping problems when starting the transform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds field validation to disallow output field names starting and/or ending with a '.'. Avoids indexing/mapping problems when starting the transform.
Note for reviewer: heavy code re-formating, ignore commit 1 and start your review with 234044f