Truncate SAML Response in trace log #51237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In not truncated, a long SAML response XML document can fill max line length and mask the actual exception message that the trace statement is meant to inform about. The same XML Document is also printed in full on trace level in SamlRequestHandler#parseSamlMessage().
jkakavas
added
>non-issue
:Security/Authentication
|
Pinging @elastic/es-security (:Security/Authentication) |
tvernum
reviewed
Jan 21, 2020
| @@ -68,7 +68,8 @@ SamlAttributes authenticate(SamlToken token) { | |||
| try { | |||
| return authenticateResponse(root, token.getAllowedSamlRequestIds()); | |||
| } catch (ElasticsearchSecurityException e) { | |||
| logger.trace("Rejecting SAML response {} because {}", SamlUtils.toString(root), e.getMessage()); | |||
| logger.trace("Rejecting SAML response {} because {}", Strings.cleanTruncate(SamlUtils.toString(root), 512), | |||
| e.getMessage()); | |||
There was a problem hiding this comment.
This is fine, but I wonder if we should indicate that we truncated ?
tvernum
approved these changes
Jan 22, 2020
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Jan 22, 2020
When not truncated, a long SAML response XML document can fill max line length and mask the actual exception message that the trace statement is meant to inform about. The same XML Document is also printed in full on trace level in SamlRequestHandler#parseSamlMessage() so there is no loss of information
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Jan 22, 2020
When not truncated, a long SAML response XML document can fill max line length and mask the actual exception message that the trace statement is meant to inform about. The same XML Document is also printed in full on trace level in SamlRequestHandler#parseSamlMessage() so there is no loss of information
jkakavas
added a commit
that referenced
this pull request
Jan 22, 2020
When not truncated, a long SAML response XML document can fill max line length and mask the actual exception message that the trace statement is meant to inform about. The same XML Document is also printed in full on trace level in SamlRequestHandler#parseSamlMessage() so there is no loss of information
jkakavas
added a commit
that referenced
this pull request
Jan 22, 2020
When not truncated, a long SAML response XML document can fill max line length and mask the actual exception message that the trace statement is meant to inform about. The same XML Document is also printed in full on trace level in SamlRequestHandler#parseSamlMessage() so there is no loss of information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In not truncated, a long SAML response XML document can fill max
line length and mask the actual exception message that the trace
statement is meant to inform about.
The same XML Document is also printed in full on trace level in
SamlRequestHandler#parseSamlMessage().