Begin moving date_histogram to offset rounding #50873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added a new rounding in elastic#50609 that handles offsets to the start and end of the rounding so that we could support `offset` in the `composite` aggregation. This starts moving `date_histogram` to that new offset.
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
|
Neat! Real test failure. |
|
@elasticmachine, run elasticsearch-ci/2 |
not-napoleon
requested changes
Jan 13, 2020
| Rounding effectiveRounding = rounding.withoutOffset(); | ||
| return new ExtendedBounds( | ||
| min != null ? effectiveRounding.round(min) : null, | ||
| max != null ? effectiveRounding.round(max) : null); |
There was a problem hiding this comment.
Excellent formatting choice, much more readable.
| @@ -153,10 +151,6 @@ public void collect(int doc, long bucket) throws IOException { | |||
| }; | |||
| } | |||
|
|
|||
| private long offsetAwareRounding(Rounding rounding, long value, long offset) { | |||
There was a problem hiding this comment.
Glad to see this getting moved into the rounding itself. Makes much more sense.
| * so keep any usage to migratory shims | ||
| */ | ||
| @Deprecated | ||
| public abstract long offset(); |
There was a problem hiding this comment.
What's the plan to migrate away from this? I'm not sure I understand the benefit to adding a deprecated method now that we intend to remove in the next PR, as opposed to just removing the need for it in this PR.
There was a problem hiding this comment.
I added this to cut the PR in half, basically. I'll remove it in a followup. I believe that follow up with have serialization changes so it'll feel pretty different than this PR.
There was a problem hiding this comment.
Seems reasonable, thanks for explaining!
not-napoleon
approved these changes
Jan 14, 2020
not-napoleon
approved these changes
Jan 14, 2020
|
Thanks @not-napoleon! |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 14, 2020
…0873) We added a new rounding in elastic#50609 that handles offsets to the start and end of the rounding so that we could support `offset` in the `composite` aggregation. This starts moving `date_histogram` to that new offset.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 17, 2020
I caused a serialization bug in elastic#50873. It is kind of tricky to get: * Run a date_histogram aggregation * On a shard on 7.6 * That shard doesn't return any results * The coordinating node is before 7.6
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 20, 2020
This reverts commit b3a7728.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 20, 2020
…lastic#50873) (elastic#50978)" This reverts commit 9a3d4db. It was subtly broken in ways we didn't have tests for.
|
I'm reverting this because it was subtly broken in ways we didn't have tests for. I'll make a PR that adds the tests and redoes it soon enough. |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 20, 2020
…lastic#50873) (elastic#50978)" This reverts commit 9a3d4db. It was subtly broken in ways we don't have tests for.
nik9000
added a commit
that referenced
this pull request
Jan 20, 2020
nik9000
added a commit
that referenced
this pull request
Jan 20, 2020
nik9000
added a commit
that referenced
this pull request
Jan 21, 2020
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 21, 2020
…ic#50873)" (elastic#51238)" This reverts commit d114c9d.
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
We added a new rounding in elastic#50609 that handles offsets to the start and end of the rounding so that we could support `offset` in the `composite` aggregation. This starts moving `date_histogram` to that new offset.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 27, 2020
) We added a new rounding in elastic#50609 that handles offsets to the start and end of the rounding so that we could support `offset` in the `composite` aggregation. This starts moving `date_histogram` to that new offset. This is a redo of elastic#50873 with more integration tests. This reverts commit d114c9d.
nik9000
added a commit
that referenced
this pull request
Jan 27, 2020
…51495) We added a new rounding in #50609 that handles offsets to the start and end of the rounding so that we could support `offset` in the `composite` aggregation. This starts moving `date_histogram` to that new offset. This is a redo of #50873 with more integration tests. This reverts commit d114c9d.
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a new rounding in #50609 that handles offsets to the start and
end of the rounding so that we could support
offsetin thecompositeaggregation. This starts moving
date_histogramto that new offset.