Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML][Inference] Unify top_classes object field names with analytics #50858

Conversation

benwtrent
Copy link
Member

Analytics writes top_classes with the fields class_name and class_probability. Inference should do the same for uniformity.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent merged commit 4ec6ec2 into elastic:master Jan 10, 2020
@benwtrent benwtrent deleted the feature/ml-inference-unify-field-names-with-analysis branch January 10, 2020 16:09
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Jan 10, 2020
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants