Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MappingUpdatedAction no unwrap #50757

Closed
wants to merge 2 commits into from
Closed

MappingUpdatedAction no unwrap #50757

wants to merge 2 commits into from

Conversation

henningandersen
Copy link
Contributor

Removed workaround for guessRootCauses returning wrapper.

Relates #50525 and #50417

@henningandersen
MappingUpdatedAction no unwrap
5b11880 
Removed workaround for guessRootCauses returning wrapper.

Relates elastic#50525 and elastic#50417
@henningandersen henningandersen added >non-issue :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. v7.6.0 labels Jan 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/CRUD)

dnhatn
dnhatn approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@henningandersen
Copy link
Contributor Author

Unfortunately, this makes the test fail due to BWC in mixed clusters, see: https://gradle-enterprise.elastic.co/s/s2vsbr5j4go3w:


java.lang.AssertionError: Failure at [delete/70_mix_typeless_typeful:33]: field [error.root_cause.0.reason] was expected to match the provided regex but didn't |  
-- | --
  | Expected: Rejecting.mapping.update.to.\[index\].as.the.final.mapping.would.have.more.than.1.type.* |  
  | but: was "[v7.5.2-3][127.0.0.1:40997][indices:admin/mapping/put]"

If the REST request hits an old node, but the bulk runs on an upgraded node, this will fail, since the new node will no longer unwrap and the old node's guessRootCauses does it wrong (thus also not unwrapping).

I am therefore closing this PR. The fix in 8.0 is OK, since rolling upgrade will work fine from 7.6 onwards.

@codebrain codebrain mentioned this pull request Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnhatn dnhatn dnhatn approved these changes

Assignees
No one assigned
Labels
:Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >non-issue v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henningandersen @elasticmachine @dnhatn