x-content: Support collapsed named objects (backport of #50564) #50619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for "collapsed" named object to `ObjectParser`. In particular, this supports the sort of xcontent that we use to specify significance heuristics. See elastic#25519 and this example: ``` GET /_search { "query" : { "terms" : {"force" : [ "British Transport Police" ]} }, "aggregations" : { "significant_crime_types" : { "significant_terms" : { "field" : "crime_type", "mutual_information" : { <<------- This is the name "include_negatives": true } } } } } ``` I believe there are a couple of things that work this way. I've held off on moving the actual parsing of the significant heuristics to this code to keep the review more compact. The moving is pretty mechanical stuff in the aggs framework.
|
@elasticmachine, run elasticsearch-ci/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for "collapsed" named object to
ObjectParser. Inparticular, this supports the sort of xcontent that we use to specify
significance heuristics. See #25519 and this example:
I believe there are a couple of things that work this way.
I've held off on moving the actual parsing of the significant heuristics
to this code to keep the review more compact. The moving is pretty
mechanical stuff in the aggs framework.