Deprecate indices without soft-deletes #50502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>deprecation
:Distributed Indexing/Distributed
|
Pinging @elastic/es-distributed (:Distributed/Distributed) |
ywelsch
suggested changes
Dec 30, 2019
qa/rolling-upgrade/src/test/java/org/elasticsearch/upgrades/RecoveryIT.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/MetaDataCreateIndexService.java
Outdated
Show resolved
Hide resolved
ywelsch
approved these changes
Dec 30, 2019
| @@ -434,6 +437,11 @@ static Settings aggregateIndexSettings(ClusterState currentState, CreateIndexClu | |||
| * that will be used to create this index. | |||
| */ | |||
| MetaDataCreateIndexService.checkShardLimit(indexSettings, currentState); | |||
| if (indexSettings.getAsBoolean(IndexSettings.INDEX_SOFT_DELETES_SETTING.getKey(), true) == false) { | |||
There was a problem hiding this comment.
Do we want to completely disallow setting this setting in 8.x? If so, should we always emit a warning, even if it's explicitly set to true?
There was a problem hiding this comment.
Users might be confused about the deprecation when creating indices for CCR in a mixed cluster between 7.x and 6.8 because they need to explicitly set the soft_deletes setting.
There was a problem hiding this comment.
If mixed clusters with 6.8 is a worry, you can just check here that all nodes are 7.0+.
With the approach here, we will still have to support the setting for the full duration of 8.x (i.e. allow people to explicitly set soft-deletes true).
There was a problem hiding this comment.
++. I will make this change in a follow-up.
|
@ywelsch Thanks for reviewing. |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jan 5, 2020
Soft-deletes will be enabled for all indices in 8.0. Hence, we should deprecate new indices without soft-deletes in 7.x.
dnhatn
added a commit
that referenced
this pull request
Jan 6, 2020
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Soft-deletes will be enabled for all indices in 8.0. Hence, we should deprecate new indices without soft-deletes in 7.x.
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
This was referenced Feb 3, 2020
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 21, 2020
Relates: #4341, elastic/elasticsearch#50502 This commit marks the enabled setting on soft delete index settings as obsolete, as setting enabled to false is deprecated.
Mpdreamz
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 21, 2020
Relates: #4341, elastic/elasticsearch#50502 This commit marks the enabled setting on soft delete index settings as obsolete, as setting enabled to false is deprecated.
github-actions bot
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 21, 2020
Relates: #4341, elastic/elasticsearch#50502 This commit marks the enabled setting on soft delete index settings as obsolete, as setting enabled to false is deprecated.
Mpdreamz
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 21, 2020
Relates: #4341, elastic/elasticsearch#50502 This commit marks the enabled setting on soft delete index settings as obsolete, as setting enabled to false is deprecated. Co-authored-by: Russ Cam <[email protected]>
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 23, 2020
Relates: #4341, elastic/elasticsearch#50502 This commit marks the enabled setting on soft delete index settings as obsolete, as setting enabled to false is deprecated. (cherry-picked from commit d86e258)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soft-deletes will be enabled for all indices in 8.0. Hence, we should deprecate new indices without soft-deletes in 7.x.