Always use soft-deletes in InternalEngine #50415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>enhancement
:Distributed Indexing/Engine
|
Pinging @elastic/es-distributed (:Distributed/Engine) |
ywelsch
reviewed
Dec 20, 2019
server/src/main/java/org/elasticsearch/index/engine/InternalEngine.java
Outdated
Show resolved
Hide resolved
ywelsch
reviewed
Dec 20, 2019
Good call. Wrapping a hard-deletes reader in a soft-deletes reader is safe and trivial. We should always do it. I think I need to go through the usage of the method |
ywelsch
approved these changes
Dec 26, 2019
Sure, will do. Thank you for reviewing :). |
dnhatn
added a commit
that referenced
this pull request
Dec 27, 2019
The InternalEngine always enables soft deletes in 8.0 regardless of the setting. We need to wait for the global checkpoint and peer recovery retention leases to be synced in these tests. Relates #50415
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Dec 29, 2019
dnhatn
added a commit
that referenced
this pull request
Dec 29, 2019
The test "testRecoverFromHardDeletesIndex" failed because the "min_retained_seqno" commit tag exists after we index using a hard-deletes engine. A hard-deletes engine must not create this commit tag; hence we need to remove it in the test. Relates #50415
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Peer recoveries become faster and use less storage (i.e., no more extra translog) with soft-deletes. Soft-deletes has been enabled by default since 7.0. We should make it mandatory in 8.0, so we can simplify the logic in the engine, recoveries, and other components. With this change, InternalEngine will always use soft-deletes regardless of the soft_deletes settings.
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
The InternalEngine always enables soft deletes in 8.0 regardless of the setting. We need to wait for the global checkpoint and peer recovery retention leases to be synced in these tests. Relates elastic#50415
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
The test "testRecoverFromHardDeletesIndex" failed because the "min_retained_seqno" commit tag exists after we index using a hard-deletes engine. A hard-deletes engine must not create this commit tag; hence we need to remove it in the test. Relates elastic#50415
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peer recoveries become faster and use less storage (i.e., no more extra translog) with soft-deletes. Soft-deletes has been enabled by default since 7.0. We should make it mandatory in 8.0, so we can simplify the logic in the engine, recoveries, and other components.
With this change, InternalEngine will always use soft-deletes regardless of the soft_deletes settings.
This PR will go to 8.0 only. I will open another PR to deprecate the soft_deletes setting (and adapt this change in other components).