add shape-type metadata to geo_shape's doc-value #50104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit serializes the ShapeType of the indexed geometry. The ShapeType can be useful for other future features. For one thing: elastic#49887 depends on the ability to determine what the highest dimensional shape is for centroid calculations. GeometryCollection is reduced to the sub-shape of the higest dimension relates elastic#37206.
these Extent assertions were breaking tests where rectangles that crossed the dateline were added. These assertions are not required within the Extent logic since it is prepared for bounding boxes that span the dateline
talevy
added
the
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
iverase
reviewed
Dec 12, 2019
server/src/main/java/org/elasticsearch/common/geo/TriangleTreeReader.java
Outdated
Show resolved
Hide resolved
This reverts commit cd77db6.
|
@iverase I tried introducing a new What is not included -> a conversion from DimensionalShapeType -> ShapeType. This would only be useful when implementing #49569 |
|
run elasticsearch-ci/bwc |
iverase
requested changes
Dec 17, 2019
server/src/main/java/org/elasticsearch/common/geo/TriangleTreeReader.java
Outdated
Show resolved
Hide resolved
|
run elasticsearch-ci/1 |
|
run elasticsearch-ci/1 |
iverase
reviewed
Dec 18, 2019
| @@ -33,8 +33,8 @@ | |||
| * relations against the serialized triangle tree. | |||
| */ | |||
| public class TriangleTreeReader { | |||
| private static final int CENTROID_HEADER_SIZE_IN_BYTES = 9; | |||
There was a problem hiding this comment.
Maybe add a comment where this 9 bytes are coming from.
There was a problem hiding this comment.
I will update this in the follow-up PR when this is modified to include the centroid weight!
iverase
approved these changes
Dec 18, 2019
|
thanks Ignacio! |
talevy
added a commit
that referenced
this pull request
Dec 19, 2019
This commit serializes the ShapeType of the indexed geometry. The ShapeType can be useful for other future features. For one thing: #49887 depends on the ability to determine what the highest dimensional shape is for centroid calculations. GeometryCollection is reduced to the sub-shape of the highest dimension relates #37206.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit serializes the ShapeType of the indexed
geometry. The ShapeType can be useful for other future
features. For one thing: #49887 depends on the ability
to determine what the highest dimensional shape is
for centroid calculations.
Since GeometryCollection is opaque, an additional
piece of data about the highest-dimension contained
within it is serialized and resolved at the time of reading.
This overhead is only present when indexing GeometryCollection.
relates #49569, #37206.