Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Upgrade jcodings dependency to 1.0.44 (#43334)" #48899

Merged

Conversation

henningandersen
Copy link
Contributor

This reverts commit 08a3549 and adds a
test that demonstrates that grok with ignore case fails with the new
dependency (jcodings 1.0.44 has a breaking change compared to 1.0.12,
also requiring an upgrade of joni).

This would crash ES with a NoSuchFieldErrror when using case insensitive matching.

I will forward port the test to 7.5, 7.x and master after merge.

This reverts commit 08a3549 and adds a
test that demonstrates that grok with ignore case fails with the new
dependency (jcodings 1.0.44 has a breaking change compared to 1.0.12,
also requiring an upgrade of joni).
@henningandersen henningandersen added >bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v7.4.3 labels Nov 7, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Ingest)

Copy link
Contributor

@spinscale spinscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for catching that one.

LGTM once CI passes

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@henningandersen
Copy link
Contributor Author

Notice that this was already fixed by #47374 when this change in 7.4 was done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v7.4.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants