Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not intercept renew requests from other tests #48833

Merged
merged 1 commit into from
Nov 2, 2019

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Nov 2, 2019

We might have some outstanding renew retention lease requests after a shard has unfollowed. If the test testRetentionLeaseIsAddedIfItDisappearsWhileFollowing intercepts a renew request from other tests then we will never unlatch and the test will time out.

Closes #45192

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/CCR Issues around the Cross Cluster State Replication features v8.0.0 v7.5.0 v7.6.0 v6.8.5 v7.4.3 labels Nov 2, 2019
@dnhatn dnhatn requested a review from jasontedor November 2, 2019 16:56
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/CCR)

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch.

@dnhatn
Copy link
Member Author

dnhatn commented Nov 2, 2019

Thanks @jasontedor.

@dnhatn dnhatn merged commit 7903b8c into elastic:master Nov 2, 2019
@dnhatn dnhatn deleted the do-not-intercept branch November 2, 2019 22:44
dnhatn added a commit that referenced this pull request Nov 3, 2019
We might have some outstanding renew retention lease requests after a 
shard has unfollowed. If testRetentionLeaseIsAddedIfItDisappearsWhileFollowing
intercepts a renew request from other tests then we will never unlatch 
and the test will time out.

Closes #45192
dnhatn added a commit that referenced this pull request Nov 3, 2019
We might have some outstanding renew retention lease requests after a 
shard has unfollowed. If testRetentionLeaseIsAddedIfItDisappearsWhileFollowing
intercepts a renew request from other tests then we will never unlatch 
and the test will time out.

Closes #45192
dnhatn added a commit that referenced this pull request Nov 3, 2019
We might have some outstanding renew retention lease requests after a 
shard has unfollowed. If testRetentionLeaseIsAddedIfItDisappearsWhileFollowing
intercepts a renew request from other tests then we will never unlatch 
and the test will time out.

Closes #45192
dnhatn added a commit that referenced this pull request Nov 3, 2019
We might have some outstanding renew retention lease requests after a
shard has unfollowed. If testRetentionLeaseIsAddedIfItDisappearsWhileFollowing
intercepts a renew request from other tests then we will never unlatch
and the test will time out.

Closes #45192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/CCR Issues around the Cross Cluster State Replication features >test Issues or PRs that are addressing/adding tests v6.8.5 v7.4.3 v7.5.0 v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Timeouts in CcrRetentionLeaseIT#testRetentionLeaseIsAddedIfItDisappearsWhileFollowing
4 participants