Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Reformat decimal digit token filter #48722

Merged
merged 2 commits into from
Nov 1, 2019
Merged

[DOCS] Reformat decimal digit token filter #48722

merged 2 commits into from
Nov 1, 2019

Conversation

jrodewig
Copy link
Contributor

Reformats the decimal digit token filter docs as part of #44726.

Changes

  • Adds a title abbreviation
  • Updates the description and adds a Lucene link
  • Adds analyze and custom analyzer snippets

@jrodewig jrodewig added >docs General docs changes :Search Relevance/Analysis How text is split into tokens v8.0.0 v7.5.0 v7.6.0 v7.4.2 labels Oct 30, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Analysis)

Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's odd that this is a tokenfilter rather than a charfilter, but that's a matter for lucene rather than a docs issue :)

It might be useful to add a token to the analysis example that mixes bengali numbers and text, to illustrate that the filter operates on characters and not just whole tokens.

@jrodewig
Copy link
Contributor Author

jrodewig commented Nov 1, 2019

Thanks @romseygeek. Good point re: mixing numbers and text. I'll update the analysis example accordingly.

@jrodewig jrodewig merged commit 8ce338e into elastic:master Nov 1, 2019
@jrodewig jrodewig deleted the decimal-digital-tokenfilter branch November 1, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants