-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Reformat decimal digit token filter #48722
Conversation
Pinging @elastic/es-docs (>docs) |
Pinging @elastic/es-search (:Search/Analysis) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It's odd that this is a tokenfilter rather than a charfilter, but that's a matter for lucene rather than a docs issue :)
It might be useful to add a token to the analysis example that mixes bengali numbers and text, to illustrate that the filter operates on characters and not just whole tokens.
Thanks @romseygeek. Good point re: mixing numbers and text. I'll update the analysis example accordingly. |
Reformats the decimal digit token filter docs as part of #44726.
Changes