Fix ref count handling in Engine.failEngine #48639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can run into an already closed store here and hence throw on trying to increment the ref count => moving to the guarded ref count increment closes elastic#48625
original-brownbear
added
>non-issue
:Distributed Indexing/Recovery
|
Pinging @elastic/es-distributed (:Distributed/Recovery) |
| @@ -490,7 +490,6 @@ public void testIndexAndRelocateConcurrently() throws Exception { | |||
| docs[i] = client().prepareIndex("test").setId(id).setSource("field1", English.intToEnglish(numDocs + i)); | |||
| } | |||
| indexRandom(true, docs); | |||
| numDocs *= 2; | |||
There was a problem hiding this comment.
this line is just dead code we're never touching numDocs again in this test :)
|
Thanks @dnhatn ! Sorry for pushing |
dnhatn
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
LGTM. The new fix is better. Thanks @original-brownbear for an extra iteration :)
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Oct 29, 2019
We can run into an already closed store here and hence throw on trying to increment the ref count => moving to the guarded ref count increment closes elastic#48625
original-brownbear
added a commit
that referenced
this pull request
Oct 30, 2019
dnhatn
pushed a commit
that referenced
this pull request
Nov 3, 2019
|
I have backported this PR to 7.5 since #48414 needs it. |
mfussenegger
added a commit
to crate/crate
that referenced
this pull request
Apr 30, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can run into an already closed store here and hence
throw on trying to increment the ref count => moving to
the guarded ref count increment
closes #48625