Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated include-type methods from HLRC indices client #48471

Merged

Conversation

romseygeek
Copy link
Contributor

We have a number of deprecated methods on the high-level Rest client's
IndicesClient that take server-side object classes and allow users to pass
the include_type_name parameter. These all have equivalent methods that
use HLRC classes instead, the only difference being the lack of the types
parameter.

This commit removes these deprecated methods.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Java High Level REST Client)

Copy link
Contributor

@mayya-sharipova mayya-sharipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romseygeek Thanks Alan, makes sense

Copy link
Contributor

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good to me!

@epixa
Copy link
Contributor

epixa commented Oct 25, 2019

I don’t think this should have any impact on Kibana, FYI

@romseygeek romseygeek merged commit d5ed817 into elastic:master Oct 29, 2019
@romseygeek romseygeek deleted the types-removal/hlrc-deprecated-methods branch October 29, 2019 09:44
@jpountz jpountz mentioned this pull request Nov 1, 2019
66 tasks
@pgomulka pgomulka mentioned this pull request Mar 25, 2020
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking-java :Data Management/Indices APIs APIs to create and manage indices and templates v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants