Deprecate the sparse_vector field type. #48315
Conversation
jtibshirani
added
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
| @@ -142,6 +147,8 @@ public SparseVectorFieldType fieldType() { | |||
|
|
|||
| @Override | |||
| public void parse(ParseContext context) throws IOException { | |||
| deprecationLogger.deprecatedAndMaybeLog("sparse_vector", DEPRECATION_MESSAGE); | |||
|
|
|||
There was a problem hiding this comment.
should we issue a deprecation logging only when parsing a sparse_vector mapping in public Mapper.Builder<?,?> parse(..) instead of issuing it every time when parsing a document with a sparse_vector?
There was a problem hiding this comment.
Yes, sorry I asked you to review a bit too early :) I still need to fix this, plus some failing docs tests.
jtibshirani
force-pushed
the
deprecate-sparse-vector
branch
from
efb6e84 to
fa5408b
Compare
We have not seen much adoption of this experimental field type, and don't see a clear use case as it's currently designed. This PR deprecates the field type in 7.x. It will be removed from 8.0 in a follow-up PR.
jtibshirani
force-pushed
the
deprecate-sparse-vector
branch
from
fa5408b to
1372639
Compare
|
@mayya-sharipova this is now ready for another look, apologies again for the false start! |
|
@elasticmachine run elasticsearch-ci/packaging-sample-matrix |
There was a problem hiding this comment.
@jtibshirani Thanks Julie, this looks good to me, as long as we have decided to remove sparse vectors in 8.0
|
@elasticmachine run elasticsearch-ci/packaging-sample-matrix |
1 similar comment
|
@elasticmachine run elasticsearch-ci/packaging-sample-matrix |
jtibshirani
added
:Search Relevance/Vectors
We have not seen much adoption of this experimental field type, and don't see a
clear use case as it's currently designed. This PR deprecates the field type in
7.x. It will be removed from 8.0 in a follow-up PR.
We issue a deprecation warning both when parsing the
sparse_vectormapping,and when a sparse vector function is passed to a script.