Relative paths, jornalctl in additional logs #48276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the archive generation to preserve the paths relative to the project directory. It also fixes callign journalctl to get the system log.
alpar-t
added
:Delivery/Build
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
|
@elasticmachine run |
mark-vieira
approved these changes
Oct 21, 2019
gradle/build-complete.gradle
Outdated
| .onMac { | ||
|
|
||
| } | ||
| if (OS.current() != OS.WINDOWS) { |
There was a problem hiding this comment.
I think we only want this to run on Linux since journalctl doesn't exist on OSX.
|
@elasticmachine run elasticsearch-ci/2 |
|
@elaticmachine run elasticsearch-ci/2 and run elasticsearch-ci/packaging-sample-matrix |
alpar-t
added a commit
that referenced
this pull request
Oct 22, 2019
* Relative paths, jornalctl in additional logs This PR fixes the archive generation to preserve the paths relative to the project directory. It also fixes calling journalctl to get the system log. * explicitly remove the file we are building * Skip files locked on windows * Extended readability probe * Try to read the file ahead on windows * Make the tar a best effort * Catch all exceptions
alpar-t
added a commit
that referenced
this pull request
Oct 22, 2019
* Relative paths, jornalctl in additional logs This PR fixes the archive generation to preserve the paths relative to the project directory. It also fixes calling journalctl to get the system log. * explicitly remove the file we are building * Skip files locked on windows * Extended readability probe * Try to read the file ahead on windows * Make the tar a best effort * Catch all exceptions
alpar-t
added a commit
that referenced
this pull request
Oct 22, 2019
* Relative paths, jornalctl in additional logs This PR fixes the archive generation to preserve the paths relative to the project directory. It also fixes calling journalctl to get the system log. * explicitly remove the file we are building * Skip files locked on windows * Extended readability probe * Try to read the file ahead on windows * Make the tar a best effort * Catch all exceptions
|
I got a couple of issues running this under elasticsearch-ci: |
|
I don't think we have any restrictions on sizing ... anyhow this is no longer be considered a fatal error in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the archive generation to preserve the paths relative to
the project directory.
It also fixes calling journalctl to get the system log.