Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TESTING.asciidoc for new :qa:os test style #48023

Merged

Conversation

williamrandolph
Copy link
Contributor

The TESTING.asciidoc document had gotten out of date due to some new and
wonderful changes in our vagrant testing code. I've taken a first cut at
some updates here.

Ryan and co. have done a lot to move coordinating code from various little scripts into Gradle tasks and plugins, so we have lost some of the "granularity" we used to have.

I'm sure I'll be cleaning this up a little once I see what it looks like in GitHub.

The TESTING.asciidoc document had gotten out of date due to some new and
wonderful changes in our vagrant testing code. I've taken a first cut at
some updates here.
@williamrandolph williamrandolph added >docs General docs changes v8.0.0 labels Oct 14, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@jrodewig jrodewig added the :Delivery/Build Build or test infrastructure label Oct 14, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Build)

@williamrandolph
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/bwc

1 similar comment
@williamrandolph
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/bwc

TESTING.asciidoc Outdated Show resolved Hide resolved
TESTING.asciidoc Outdated Show resolved Hide resolved
@@ -657,7 +619,7 @@ care.
== Test coverage analysis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wonder if we can remove this whole section. Test coverage analysis is not part of our development process in any formal way. This assumes that contributors want some way of analyzing test coverage themselves? I'm not sure just saying "you're on your own" is even worth mentioning.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave that for a separate issue, since this PR is about packaging test docs.

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have a few minor suggestions.

TESTING.asciidoc Outdated Show resolved Hide resolved
TESTING.asciidoc Outdated Show resolved Hide resolved
TESTING.asciidoc Outdated Show resolved Hide resolved
TESTING.asciidoc Outdated Show resolved Hide resolved
@@ -657,7 +619,7 @@ care.
== Test coverage analysis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave that for a separate issue, since this PR is about packaging test docs.

I've edited a few instructions for style, clarity, and correctness.
Furthermore, I've removed the unwieldy instructions for mimicking the
Gradle plugin using shell commands.
@williamrandolph
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/packaging-sample

@williamrandolph
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/packaging-sample-matrix

@williamrandolph williamrandolph merged commit 19ae454 into elastic:master Oct 16, 2019
@williamrandolph williamrandolph deleted the packaging-test-doc-update branch October 16, 2019 20:25
williamrandolph added a commit that referenced this pull request Oct 16, 2019
* Update testing document for new packaging tests

The TESTING.asciidoc document had gotten out of date due to some new and
wonderful changes in our vagrant testing code. I've removed all of the
instructions that no longer work, and added working examples and descriptions
in their place.
williamrandolph added a commit that referenced this pull request Oct 16, 2019
* Update testing document for new packaging tests

The TESTING.asciidoc document had gotten out of date due to some new and
wonderful changes in our vagrant testing code. I've removed all of the
instructions that no longer work, and added working examples and descriptions
in their place.
williamrandolph added a commit that referenced this pull request Oct 16, 2019
* Update testing document for new packaging tests

The TESTING.asciidoc document had gotten out of date due to some new and
wonderful changes in our vagrant testing code. I've removed all of the
instructions that no longer work, and added working examples and descriptions
in their place.
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure >docs General docs changes Team:Delivery Meta label for Delivery team v7.4.2 v7.5.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants