-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TESTING.asciidoc for new :qa:os test style #48023
Update TESTING.asciidoc for new :qa:os test style #48023
Conversation
The TESTING.asciidoc document had gotten out of date due to some new and wonderful changes in our vagrant testing code. I've taken a first cut at some updates here.
Pinging @elastic/es-docs (>docs) |
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
@elasticmachine run elasticsearch-ci/bwc |
1 similar comment
@elasticmachine run elasticsearch-ci/bwc |
@@ -657,7 +619,7 @@ care. | |||
== Test coverage analysis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wonder if we can remove this whole section. Test coverage analysis is not part of our development process in any formal way. This assumes that contributors want some way of analyzing test coverage themselves? I'm not sure just saying "you're on your own" is even worth mentioning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave that for a separate issue, since this PR is about packaging test docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I have a few minor suggestions.
@@ -657,7 +619,7 @@ care. | |||
== Test coverage analysis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave that for a separate issue, since this PR is about packaging test docs.
I've edited a few instructions for style, clarity, and correctness. Furthermore, I've removed the unwieldy instructions for mimicking the Gradle plugin using shell commands.
@elasticmachine run elasticsearch-ci/packaging-sample |
@elasticmachine run elasticsearch-ci/packaging-sample-matrix |
* Update testing document for new packaging tests The TESTING.asciidoc document had gotten out of date due to some new and wonderful changes in our vagrant testing code. I've removed all of the instructions that no longer work, and added working examples and descriptions in their place.
* Update testing document for new packaging tests The TESTING.asciidoc document had gotten out of date due to some new and wonderful changes in our vagrant testing code. I've removed all of the instructions that no longer work, and added working examples and descriptions in their place.
* Update testing document for new packaging tests The TESTING.asciidoc document had gotten out of date due to some new and wonderful changes in our vagrant testing code. I've removed all of the instructions that no longer work, and added working examples and descriptions in their place.
The TESTING.asciidoc document had gotten out of date due to some new and
wonderful changes in our vagrant testing code. I've taken a first cut at
some updates here.
Ryan and co. have done a lot to move coordinating code from various little scripts into Gradle tasks and plugins, so we have lost some of the "granularity" we used to have.
I'm sure I'll be cleaning this up a little once I see what it looks like in GitHub.