-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the documentation for create_doc privilege #47784
Correct the documentation for create_doc privilege #47784
Conversation
Pinging @elastic/es-docs (>docs) |
Pinging @elastic/es-security (:Security/Authorization) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should still keep the note that this privilege requires the op_type create on the index / bulk API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you have a look as well, @lcawl?
@elasticmachine run elasticsearch-ci/2 |
`create`. | ||
[NOTE] | ||
==== | ||
This privilege relies on the `op_type` of indexing requests (<<docs-index_>> and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This privilege relies on....
It seems to me that the implication here is that when you have only create_doc privilege, you cannot use the index or bulk APIs successfully unless you use one of the three options below. If that's true, I don't think we're making that dependency clear enough. I'd suggest changing "the op_type can be set to create..." to something like "...you must set the op_type to create..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you index a document (with no '_id'), then the 'op_type' is set to 'create' internally. I think the implication is correct here but open for other suggestions. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps something more like you must ensure that the op_type is set to create ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd like to give @lcawl a chance to have another look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@elasticmachine update branch |
Merging despite CLA status, as the author was an Elastic employee when the development work was done |
The documentation was added in elastic#47584 but those docs did not reflect the up-to-date behavior of the feature. Backport of: elastic#47784
The documentation was added in elastic#47584 but those docs did not reflect the up-to-date behavior of the feature. Backport of: elastic#47784
The backport PR seems to have been merged. I'm therefore removing the backport pending label here. Please shout if this is incorrect |
The documentation was added in #47584 but the behavior was changed which did not reflect in the documentation. This commit removes the note that is not needed anymore.
Preview: http://elasticsearch_47784.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/security-privileges.html