Eliminate Gradle task input warnings #47538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Vieira <[email protected]>
Signed-off-by: Mark Vieira <[email protected]>
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
Signed-off-by: Mark Vieira <[email protected]>
Signed-off-by: Mark Vieira <[email protected]>
Signed-off-by: Mark Vieira <[email protected]>
Signed-off-by: Mark Vieira <[email protected]>
|
@elasticmachine update branch |
rjernst
approved these changes
Oct 4, 2019
|
@elasticmachine run elasticsearch-ci/docs |
alpar-t
reviewed
Oct 4, 2019
| @@ -49,11 +50,16 @@ public Chmod getChmod() { | |||
| throw new UnsupportedOperationException(); | |||
| } | |||
|
|
|||
| @Input | |||
| @Internal | |||
There was a problem hiding this comment.
I'm assuming a non existing File can't be input ?
There was a problem hiding this comment.
The issue here was Gradle was complaining that we were using @Input for File when we should have been using @InputFile or @InputDirectory. Using @Input tracks the File path, not it's contents, which is actually the behavior we want, but Gradle is issuing a warning here because we aren't being explicit. That's why I've added the input for the directory path, which is all we care about.
alpar-t
approved these changes
Oct 4, 2019
mark-vieira
added a commit
that referenced
this pull request
Oct 4, 2019
(cherry picked from commit e86d40f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a number of tasks that either omit, or incorrectly apply Gradle input/output annotations on task properties. In addition to some of these instances resulting in potentially incorrect incremental build behavior, this causes a bunch of noise whenever we build
:buildSrc. This PR addresses these reported warnings.