-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add doc_values
mapping option to geo_shape field mapping
#47519
Conversation
This PR adds TypeParsers.parseField to the fieldType parsing in AbstractGeometryFieldMapper. This enables support for common mapping configuration options like `copy_to`, `doc_values`, `store`, `index`, `index_options`. some options are not necessarily used, but all MappedFieldTypes recognize them: `similarity`, `boost`.
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might make sense to add tests for everything that we added support for here. I played with copy_to
for a bit and it looks like it no longer complain about it being present, but it doesn't seem to copy anything.
+1 to add tests to the different options. |
ah, thanks for the reviews. I didn't realize more had to be implemented on that front. thought all the copy_to behavior would be inherited |
doc_values
mapping option to geo_shape field mapping
Hi Igor, after re-visiting this / forgetting about it... I realize that it is unclear how to support other options that TypeParsers supports like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like there are still a few bits missing. For example I would expect it to show up in doXContentBody as well if have some merge handling.
server/src/test/java/org/elasticsearch/index/mapper/LegacyGeoShapeFieldMapperTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/mapper/GeoShapeFieldMapperTests.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR adds support for the `doc_values` field mapping parameter. `true` and `false` supported by the GeoShapeFieldMapper, only `false` is supported by the LegacyGeoShapeFieldMapper. relates #37206
This PR adds support for the
doc_values
field mapping parameter.true
andfalse
supported by the GeoShapeFieldMapper,only
false
is supported by the LegacyGeoShapeFieldMapper.relates #37206