Geo: Fixes indexing of linestrings that go around the globe #47471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LINESTRING (0 0, 720 20) is now decomposed into 3 strings: multilinestring ( (0.0 0.0, 180.0 5.0), (-180.0 5.0, 180 15), (-180.0 15.0, 0 20) ) It also fixes issues with linestrings that intersect antimeridian more than 5 times. Fixes elastic#43837 Fixes elastic#43826
imotov
added
>bug
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
…ound-the-world-linestring
talevy
reviewed
Oct 8, 2019
| } | ||
| return lines; | ||
| } | ||
|
|
||
| double calculateShift(double lon, int direction) { |
There was a problem hiding this comment.
since this is a very specific operation/definition of a normalized lon, maybe javadocs would be helpful here
| lons[offset + i - 1] = intersection.getX(); | ||
| lats[offset + i - 1] = intersection.getY(); | ||
|
|
||
| double shift = 0; |
There was a problem hiding this comment.
I find it difficult to keep this, calculateShift(..), and shift(..) separate. would some more distinct naming help, or would that just make things more confusing?
There was a problem hiding this comment.
shift is used all over the place and it is the actual shift as opposed to the amount of shift getting calculated and stored. I have renamed the method shift into performShift() here, I will rename the rest of them as I go through the changes in the areas where they are used.
…ound-the-world-linestring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes indexing of linestrings that go around the globe.
LINESTRING (0 0, 720 20)is now decomposed into 3 strings:It also fixes issues with linestrings that intersect antimeridian
more than 5 times and adds optimization of decomposition
by -180 and 180 degrees at the same time.
Fixes #43837
Fixes #43826