Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alias field resolution in match query #47369

Merged
merged 3 commits into from
Oct 2, 2019

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Oct 1, 2019

Synonym queries (when two tokens/paths start at the same position) use the alias field instead
of the concrete field to build Lucene queries. This commit fixes this bug by resolving the alias field
upfront in order to provide the concrete field to the actual query parser.

Synonym queries (when two tokens/paths start at the same position) use the alias field instead
of the concrete field to build Lucene queries. This commit fixes this bug by resolving the alias field
upfront in order to provide the concrete field to the actual query parser.
@jimczi jimczi added >bug :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.5.0 labels Oct 1, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

Copy link
Contributor

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

The interaction between field alias resolution and flattened fields is a bit complicated. I've made a note to look into a refactor to make it less fragile.

@jimczi
Copy link
Contributor Author

jimczi commented Oct 1, 2019

@elasticmachine run elasticsearch-ci/1

@jimczi jimczi merged commit cea5add into elastic:master Oct 2, 2019
@jimczi jimczi deleted the bug/alias_field_complex_query branch October 2, 2019 07:54
jimczi added a commit that referenced this pull request Oct 2, 2019
Synonym queries (when two tokens/paths start at the same position) use the alias field instead
of the concrete field to build Lucene queries. This commit fixes this bug by resolving the alias field upfront in order to provide the concrete field to the actual query parser.
jimczi added a commit that referenced this pull request Oct 4, 2019
Synonym queries (when two tokens/paths start at the same position) use the alias field instead
of the concrete field to build Lucene queries. This commit fixes this bug by resolving the alias field upfront in order to provide the concrete field to the actual query parser.
@jimczi jimczi added the v7.4.1 label Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Search/Search Search-related issues that do not fall into other categories v7.4.1 v7.5.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants