Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Add alias DATETRUNC to DATE_TRUNC function #47173

Merged
merged 3 commits into from
Sep 27, 2019
Merged

SQL: Add alias DATETRUNC to DATE_TRUNC function #47173

merged 3 commits into from
Sep 27, 2019

Conversation

matriv
Copy link
Contributor

@matriv matriv commented Sep 26, 2019

To be on the safe side in terms of use cases also add the alias
DATETRUNC to the DATE_TRUNC function.

Follows: #46473

@matriv
SQL: Add alias DATETRUNC to DATE_TRUNC function
07d22a8 
To be on the safe side in terms of use cases also add the alias
DATETRUNC to the DATE_TRUNC function.

Follows: elastic#46473
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@matriv
Copy link
Contributor Author

matriv commented Sep 26, 2019

Not sure if it should be marked as enhancement (for release notes) or non-issue.
@costin ?

@matriv
Copy link
Contributor Author

matriv commented Sep 27, 2019

@elasticmachine run elasticsearch-ci/bwc

@costin
Copy link
Member

costin commented Sep 27, 2019

You could mark it as a feature since it's a new function.

costin
costin approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matriv matriv merged commit 9ac223c into elastic:master Sep 27, 2019
@matriv matriv deleted the add-alias-datetrunc branch September 27, 2019 12:38
matriv added a commit that referenced this pull request Sep 27, 2019
@matriv
SQL: Add alias DATETRUNC to DATE_TRUNC function (#47173)
01623f9 
To be on the safe side in terms of use cases also add the alias
DATETRUNC to the DATE_TRUNC function.

Follows: #46473

(cherry picked from commit 9ac223c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costin costin costin approved these changes

@astefan astefan Awaiting requested review from astefan

@bpintea bpintea Awaiting requested review from bpintea

Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >feature v7.5.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matriv @elasticmachine @costin @jakelandis