Reindex Throttle Checkpointing #46763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than write every time, we now only write at certain intervals. Revamped the single-writer and finish handling around this to avoid any waiting. Relates elastic#42612
henningandersen
added
>enhancement
v8.0.0
:Distributed Indexing/Reindex
|
Pinging @elastic/es-distributed |
|
ci/2 failure reported here: #46907 so |
…_throttle_checkpointing
Tim-Brooks
approved these changes
Sep 23, 2019
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Sep 23, 2019
Only send back task-id to client after all subtasks have started to stay compatible with tests requiring this. Relates elastic#46763 (test failure) and elastic#42612
ywelsch
reviewed
Sep 23, 2019
| this.value = newValue; | ||
| if (scheduledWrite == null) { | ||
| // schedule is non-blocking | ||
| scheduledWrite = threadPool.schedule(this::onScheduleTimeout, getDelay(now), ThreadPool.Names.SAME); |
There was a problem hiding this comment.
schedule loses the thread context. Given that we are afterwards writing to an index (possibly running with security enabled), I wonder if that thread context is relevant.
|
ci/1 failure to run |
henningandersen
added a commit
that referenced
this pull request
Sep 24, 2019
…_throttle_checkpointing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than write checkpoints every time, we now only write at certain intervals.
Revamped the single-writer and finish handling around this to avoid any
waiting/blocking.
Relates #42612