Don't require mapping if specified in the request #4671
Conversation
|
the main problem here is that a top level mapping can have more than just you will see that a few lines above, there is a check that checks for a single top level object, and fails with an exception that says it must be a type. if this change is in, this needs to be fixed as well. I commented on this issue, but we have to make this change backward comp. to support older indices. |
|
@kimchy I've updated this PR so that it supports multiple top-level objects and is entirely backwards-compatible. |
|
I think this patch looks good. The only thing that I think we should improve is the nameing of the commit, I had to go to the issues to figure out what this is about :) |
Put mapping now supports either of these formats:
POST foo/doc/_mapping
{
"doc": {
"_routing": {"required": true},
"properties": {
"body": {"type": "string"}
}
}
}
or
POST foo/doc/_mapping
{
"_routing": {"required": true},
"properties": {
"body": {"type": "string"}
}
}
Closes elastic#4483
|
Merged in 2341825 |
This fixes #4483 and is backwards-compatible with our current behavior.