Delay the creation of SubSearchContext to the FetchSubPhase #46598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change delays the creation of the SubSearchContext for nested and parent/child inner_hits to the fetch sub phase in order to ensure that a SearchContext can built entirely from a QueryShardContext. This commit also adds a validation step to the inner hits builder that ensures that we fail the request early if the inner hits path is invalid. Relates elastic#46523
jimczi
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search |
8 tasks
javanna
reviewed
Sep 11, 2019
| @@ -765,7 +762,7 @@ private void parseSource(DefaultSearchContext context, SearchSourceBuilder sourc | |||
| } catch (IOException e) { | |||
| throw new SearchContextException(context, "failed to create sort elements", e); | |||
| } | |||
| } | |||
| }NestedQueryBuilderTestsNestedQueryBuilderTests | |||
There was a problem hiding this comment.
leftover I guess :) I do this all the time
There was a problem hiding this comment.
lol, yep just before I commit
javanna
approved these changes
Sep 12, 2019
jimczi
added a commit
that referenced
this pull request
Sep 12, 2019
This change delays the creation of the SubSearchContext for nested and parent/child inner_hits to the fetch sub phase in order to ensure that a SearchContext can built entirely from a QueryShardContext. This commit also adds a validation step to the inner hits builder that ensures that we fail the request early if the inner hits path is invalid. Relates #46523
jimczi
added a commit
that referenced
this pull request
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change delays the creation of the SubSearchContext for nested and parent/child inner_hits
to the fetch sub phase in order to ensure that a SearchContext can built entirely from a
QueryShardContext. This commit also adds a validation step to the inner hits builder that ensures
that we fail the request early if the inner hits path is invalid.
Relates #46523