Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Apostrophe #46472

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Added Apostrophe #46472

merged 1 commit into from
Sep 9, 2019

Conversation

khansuhel
Copy link
Contributor

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

cbuescher
cbuescher approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice typo fix.

@cbuescher
Copy link
Member

@elasticmachine test this please

@cbuescher cbuescher merged commit b10afcc into elastic:7.3 Sep 9, 2019
cbuescher pushed a commit that referenced this pull request Sep 9, 2019
@khansuhel
[Docs] Fix typo in minimum-should-match.asciidoc (#46472)
948ea49
cbuescher pushed a commit that referenced this pull request Sep 9, 2019
@khansuhel
[Docs] Fix typo in minimum-should-match.asciidoc (#46472)
d5529cb
cbuescher pushed a commit that referenced this pull request Sep 9, 2019
@khansuhel
[Docs] Fix typo in minimum-should-match.asciidoc (#46472)
4747892
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@colings86 colings86 added v7.4.0 and removed v7.4.1 labels Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbuescher cbuescher cbuescher approved these changes

Assignees
No one assigned
Labels
>docs General docs changes v7.3.3 v7.4.0 v7.5.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@khansuhel @cbuescher @elasticmachine @colings86 @jakelandis