Add geo_shape support to geo_centroid aggregation #46299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit annotates geometries with centroid information at index-time. Then each shapes centroid is used as input to the geo_centroid aggregator so that it effectively calculates the centroid of centroids of shapes within each bucket. The centroid of each geo_shape field is calculated as the centroid of all the points of all the shapes in the geometry collection. The centroid of each shape is calculated the same way geo_centroid was -- using a kahan-summation to reduce precision loss.
talevy
added
the
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo |
imotov
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
Sorry for the delay. LGTM. I think it might be good for @polyfractal to take a look at it as well from aggregations perspective.
polyfractal
approved these changes
Sep 10, 2019
|
thanks all! |
talevy
added a commit
that referenced
this pull request
Sep 20, 2019
* Add geo_shape support to geo_centroid aggregation This commit annotates geometries with centroid information at index-time. Then each shapes centroid is used as input to the geo_centroid aggregator so that it effectively calculates the centroid of centroids of shapes within each bucket. The centroid of each geo_shape field is calculated as the centroid of all the points of all the shapes in the geometry collection. The centroid of each shape is calculated the same way geo_centroid was -- using a kahan-summation to reduce precision loss. * add centroid test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit annotates geometries with centroid information
at index-time. Then each shapes centroid is used as input to
the geo_centroid aggregator so that it effectively calculates
the centroid of centroids of shapes within each bucket.
The centroid of each geo_shape field is calculated as the
centroid of all the points of all the shapes in the geometry
collection.
The centroid of each shape is calculated the same way geo_centroid
was -- using a kahan-summation to reduce precision loss.
relates to #37206