Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] Fix assertion regarding instanceof exception #46126

Closed
wants to merge 1 commit into from
Closed

[TEST] Fix assertion regarding instanceof exception #46126

wants to merge 1 commit into from

Conversation

matriv
Copy link
Contributor

@matriv matriv commented Aug 29, 2019

During refactoring to use assertThat the assertion was converted wrongly causing:

Expected: an instance of org.elasticsearch.transport.NodeDisconnectedException
    but: <class org.elasticsearch.transport.NodeDisconnectedException> is a java.lang.Class

Follows: #45899

@matriv matriv added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Network Http and internode communication implementations v8.0.0 labels Aug 29, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@pugnascotia
Copy link
Contributor

I've already pushed a revert to master for all the changes after @DaveCTurner alerted me to this exact issue. Apologies for the inconvenience.

@matriv matriv deleted the mt/fix-test branch August 29, 2019 12:50
@matriv
Copy link
Contributor Author

matriv commented Aug 29, 2019 •
edited
Loading

@pugnascotia ah, sorry, missed commit that reverted the refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pugnascotia pugnascotia Awaiting requested review from pugnascotia

Assignees
No one assigned
Labels
:Distributed Coordination/Network Http and internode communication implementations >test Issues or PRs that are addressing/adding tests v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matriv @elasticmachine @pugnascotia @jakelandis