Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use float instead of double for query vectors. #46004

Merged
merged 3 commits into from
Aug 28, 2019
Merged

Use float instead of double for query vectors. #46004

merged 3 commits into from
Aug 28, 2019

Commits on Aug 26, 2019

  1. Use float instead of double for query vectors. 

    Currently, when using script_score functions like cosineSimilarity, the query
vector is treated as an array of doubles. Since the stored document vectors use
floats, it seems like the least surprising behavior for the query vectors to
also be float arrays.

In addition to improving consistency, this change may help with some
optimizations we have been considering around vector dot product.
    @jtibshirani
    jtibshirani committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    3e88ac8 View commit details
    Browse the repository at this point in the history

  2. Fix failing test cases.

    @jtibshirani
    jtibshirani committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    21ef8b5 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into float-query-vector

    @jtibshirani
    jtibshirani committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    772b41d View commit details
    Browse the repository at this point in the history