Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation check for pidfile setting #45939

Merged
merged 1 commit into from
Aug 24, 2019

Conversation

jasontedor
Copy link
Member

@jasontedor jasontedor commented Aug 24, 2019

The pidfile setting is deprecated. This commit adds a deprecation check for usage of this setting.

Relates #45938
Relates #45940

The pidfile setting is deprecated. This commit adds a deprecation check
for usage of this setting.
@jasontedor jasontedor added :Core/Infra/Core Core issues without another label >deprecation v7.4.0 labels Aug 24, 2019
@jasontedor jasontedor requested review from rjernst and gwbrown August 24, 2019 13:12
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasontedor jasontedor merged commit 040a810 into elastic:7.x Aug 24, 2019
@jasontedor jasontedor deleted the pidfile-deprecation-check branch August 24, 2019 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >deprecation v7.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants