-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Improve progress reportings for DF analytics #45856
Merged
dimitris-athanasiou
merged 9 commits into
elastic:master
from
dimitris-athanasiou:better-progress-tracking-for-df-analytics
Aug 23, 2019
Merged
[ML] Improve progress reportings for DF analytics #45856
dimitris-athanasiou
merged 9 commits into
elastic:master
from
dimitris-athanasiou:better-progress-tracking-for-df-analytics
Aug 23, 2019
Commits on Aug 22, 2019
-
[ML] Improve progress reportings for DF analytics
Previously, the stats API reports a progress percentage for DF analytics tasks that are running and are in the `reindexing` or `analyzing` state. This means that when the task is `stopped` there is no progress reported. Thus, one cannot distinguish between a task that never run to one that completed. In addition, there are blind spots in the progress reporting. In particular, we do not account for when data is loaded into the process. We also do not account for when results are written. This commit addresses the above issues. It changes progress to being a list of objects, each one describing the phase and its progress as a percentage. We currently have 4 phases: reindexing, loading_data, analyzing, writing_results. When the task stops, progress is persisted as a document in the state index. The stats API now reports progress from in-memory if the task is running, or returns the persisted document (if there is one).
Configuration menu - View commit details
-
Copy full SHA for e33d175 - Browse repository at this point
Copy the full SHA e33d175View commit details
Commits on Aug 23, 2019
-
Make sure loading data progress does not go over 100
Co-Authored-By: Benjamin Trent <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a12aea2 - Browse repository at this point
Copy the full SHA a12aea2View commit details -
Make sure writing results progress does not go over 100
Co-Authored-By: Benjamin Trent <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0c61cb3 - Browse repository at this point
Copy the full SHA 0c61cb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d0d6227 - Browse repository at this point
Copy the full SHA d0d6227View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb81450 - Browse repository at this point
Copy the full SHA eb81450View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11c446e - Browse repository at this point
Copy the full SHA 11c446eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 24e506a - Browse repository at this point
Copy the full SHA 24e506aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9d97e4 - Browse repository at this point
Copy the full SHA d9d97e4View commit details -
Update x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/acti…
…on/TransportGetDataFrameAnalyticsStatsAction.java Co-Authored-By: Benjamin Trent <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d567c54 - Browse repository at this point
Copy the full SHA d567c54View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.