Make git revision loading lazy #45358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the gitRevision property a lazy loaded value by returning an Object implementing toString(). The Dockerfile template is also changed to use groovy templates instead of the mavenfilter hack, so converting to String will not happen until runtime.
rjernst
added
:Delivery/Build
|
Pinging @elastic/es-core-infra |
mark-vieira
approved these changes
Aug 8, 2019
| }); | ||
| private Object createGitRevisionResolver(final Project project) { | ||
| return new Object() { | ||
| private final AtomicReference<String> gitRevision = new AtomicReference<>(); |
There was a problem hiding this comment.
Would it be better instead of making this an AtomicReference to simply synchronize these calls so we can avoid to possibility shelling to git multiple times if this is called concurrently? I think as it is we could do that and simply the first one would win.
There was a problem hiding this comment.
While this is a possibility, I wasn't sure it was necessary to avoid. I figured it was better to make concurrent calls fast, if they happen (but it seems unlikely?). By synchronizing the method, we would still be single threading the method even after we've retrieved the hash.
There was a problem hiding this comment.
Yeah, it's hard to say either way. I'm fine with leaving as is.
rjernst
added a commit
that referenced
this pull request
Aug 9, 2019
This commit makes the gitRevision property a lazy loaded value by returning an Object implementing toString(). The Dockerfile template is also changed to use groovy templates instead of the mavenfilter hack, so converting to String will not happen until runtime.
rjernst
added a commit
that referenced
this pull request
Aug 9, 2019
This commit makes the gitRevision property a lazy loaded value by returning an Object implementing toString(). The Dockerfile template is also changed to use groovy templates instead of the mavenfilter hack, so converting to String will not happen until runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the gitRevision property a lazy loaded value by
returning an Object implementing toString(). The Dockerfile template is
also changed to use groovy templates instead of the mavenfilter hack, so
converting to String will not happen until runtime.