Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML][Data Frame] enable bwc tests again, adjusting after backport #44720

Merged
merged 1 commit into from
Jul 23, 2019
Merged

[ML][Data Frame] enable bwc tests again, adjusting after backport #44720

merged 1 commit into from
Jul 23, 2019

Conversation

benwtrent
Copy link
Member

@benwtrent benwtrent added >test Issues or PRs that are addressing/adding tests v8.0.0 :ml/Transform Transform labels Jul 22, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

droberts195
droberts195 approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

iverase pushed a commit to iverase/elasticsearch that referenced this pull request Jul 23, 2019
@Hohol @DaveCTurner
Remove support for old translog checkpoint formats (elastic#44280)
804476c 
This commit removes support for the translog checkpoint format from versions
before 6.0.0 since 7.x versions are incompatible with indices from these
versions.

Relates elastic#44720
Fixes elastic#44210
@droberts195
Copy link
Contributor

@benwtrent I just went to mute these same tests for my backport of #44350 and found they were still muted. To save churn, please could you hold off merging this PR until near the end of your day. Then I should be able to get my backport done with the same mutes.

@droberts195
Copy link
Contributor

Actually, ignore the previous comment @benwtrent. My PR is proving more problematic to backport than I thought, so since this PR is green you might as well merge it and then I'll re-mute these tests once I've fixed my backport.

@benwtrent benwtrent merged commit e22ce5a into elastic:master Jul 23, 2019
@benwtrent benwtrent deleted the tests/ml-df-unmute-bwc branch July 23, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droberts195 droberts195 droberts195 approved these changes

Assignees
No one assigned
Labels
:ml/Transform Transform >test Issues or PRs that are addressing/adding tests v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benwtrent @elasticmachine @droberts195 @jakelandis