Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AllocationService.reroute(ClusterState, String, boolean) in favor of reroute(ClusterState, String) #44629

Merged
merged 1 commit into from
Jul 22, 2019
Merged

Remove AllocationService.reroute(ClusterState, String, boolean) in favor of reroute(ClusterState, String) #44629

merged 1 commit into from
Jul 22, 2019

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Jul 19, 2019

This PR removes the method AllocationService.reroute(ClusterState, String, boolean) in favor of AllocationService.reroute(ClusterState, String).

Motivations are:

  • there are already 3 other reroute methods in this class
  • this method is always called with the debug parameter set to false
  • almost all tests use the method reroute(ClusterState, String)

@tlrx tlrx added >non-issue :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) v8.0.0 v7.4.0 labels Jul 19, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

original-brownbear
original-brownbear approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@tlrx tlrx merged commit 67e5ad2 into elastic:master Jul 22, 2019
@tlrx tlrx deleted the remove-duplicate-reroute branch July 22, 2019 15:09
@tlrx
Copy link
Member Author

tlrx commented Jul 22, 2019

Thanks @original-brownbear !

tlrx added a commit that referenced this pull request Jul 22, 2019
@tlrx
Remove AllocationService.reroute(ClusterState, String, boolean) (#44629)
bcb3563 
This commit removes the method AllocationService.reroute(ClusterState, String, boolean) 
in favor of AllocationService.reroute(ClusterState, String).

Motivations are:
    there are already 3 other reroute methods in this class
    this method is always called with the debug parameter set to false
    almost all tests use the method reroute(ClusterState, String)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@original-brownbear original-brownbear original-brownbear approved these changes

Assignees
No one assigned
Labels
:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >non-issue v7.4.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tlrx @elasticmachine @original-brownbear @jakelandis