Restore setting up temp dir for windows service #44541
Merged
+26
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In elastic#41913 setting up the temp dir for ES was moved from the env script to individual cli scripts. However, moving it to the windows service cli was missed. This commit restores setting up the temp dir for the windows service control script.
rjernst
added
>bug
:Delivery/Packaging
|
Pinging @elastic/es-core-infra |
|
Note I currently have the fix commented out here in order to ensure the new test would have caught the existing bug (I have had issues running the windows vagrant image on my local machine lately). I will restore the fix here once I see the packaging tests fail as expected. |
|
Ok, this is ready for review. Getting tests running again required a couple fixes to how the java paths are handled, and I also added future protection in case our windows script fails. |
|
@elasticmachine run elasticsearch-ci/packaging-sample |
|
@elasticmachine run elasticsearch-ci/packaging-sample |
jasontedor
reviewed
Jul 20, 2019
jasontedor
approved these changes
Jul 21, 2019
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Jul 21, 2019
In elastic#41913 setting up the temp dir for ES was moved from the env script to individual cli scripts. However, moving it to the windows service cli was missed. This commit restores setting up the temp dir for the windows service control script.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Jul 21, 2019
In elastic#41913 setting up the temp dir for ES was moved from the env script to individual cli scripts. However, moving it to the windows service cli was missed. This commit restores setting up the temp dir for the windows service control script.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Jul 21, 2019
In elastic#41913 setting up the temp dir for ES was moved from the env script to individual cli scripts. However, moving it to the windows service cli was missed. This commit restores setting up the temp dir for the windows service control script.
rjernst
added a commit
that referenced
this pull request
Jul 21, 2019
In #41913 setting up the temp dir for ES was moved from the env script to individual cli scripts. However, moving it to the windows service cli was missed. This commit restores setting up the temp dir for the windows service control script.
rjernst
added a commit
that referenced
this pull request
Jul 21, 2019
In #41913 setting up the temp dir for ES was moved from the env script to individual cli scripts. However, moving it to the windows service cli was missed. This commit restores setting up the temp dir for the windows service control script.
rjernst
added a commit
that referenced
this pull request
Jul 21, 2019
In #41913 setting up the temp dir for ES was moved from the env script to individual cli scripts. However, moving it to the windows service cli was missed. This commit restores setting up the temp dir for the windows service control script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #41913 setting up the
temp dir for ES was moved from the env script to individual cli scripts.
However, moving it to the windows service cli was missed. This commit
restores setting up the temp dir for the windows service control script.