Enable XLint warnings for ML #44285
Merged
Enable XLint warnings for ML #44285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loads of unchecked warnings in test left
|
Pinging @elastic/ml-core |
23 tasks
|
Pinging @elastic/es-core-infra |
przemekwitek
approved these changes
Jul 15, 2019
| @@ -166,7 +166,7 @@ public void testProcess_GivenTwoBatchesWhereFirstEndsWithSkippedRow() throws IOE | |||
| DataFrameDataExtractor.Row normalRow2 = newRow(newHit(dataDoc), dataValues, 2); | |||
| DataFrameDataExtractor.Row skippedRow = newRow(newHit("{}"), null, 3); | |||
| DataFrameDataExtractor.Row normalRow3 = newRow(newHit(dataDoc), dataValues, 4); | |||
| givenDataFrameBatches(Arrays.asList(normalRow1, normalRow2, skippedRow), Arrays.asList(normalRow3)); | |||
| givenDataFrameBatches(List.of(Arrays.asList(normalRow1, normalRow2, skippedRow), Arrays.asList(normalRow3))); | |||
There was a problem hiding this comment.
Could you use List.of everywhere like you did in line 217?
BTW, are you going to backport it to 7.x? This would require changing List.of to Arrays.asList everywhere.
There was a problem hiding this comment.
Yes this will be backported to 7.x which is why I didn't use List.of everywhere as I would have to undo the change in the backport.
I thought this partial change helped readability
|
@elasticmachine update branch |
davidkyle
added a commit
to davidkyle/elasticsearch
that referenced
this pull request
Jul 15, 2019
Removes the warning suppression -Xlint:-deprecation,-rawtypes,-serial,-try,-unchecked. Many warnings were unchecked warnings in the test code often because of the use of mocks. These are suppressed with @SuppressWarning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the warning suppression
-Xlint:-deprecation,-rawtypes,-serial,-try,-unchecked, deprecation is disabled by default for the entire project.Most of the warnings were
uncheckedwarnings in the test code often because of the use of mocks. These are suppressed with@SuppressWarningFor #40366