Make NodeConnectionsService non-blocking #44211
Merged
+55
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With connection management now being non-blocking, we can make
NodeConnectionsService
avoid the use of MANAGEMENT threads that are blocked during the connection attempts.I had to fiddle a bit with the tests as
testPeriodicReconnection
was using both the mock Threadpool from theDeterministicTaskQueue
as well as the real ThreadPool initialized at the test class level, which resulted in races.