Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include_type_name in indices.exitst REST API spec #43910

Closed
wants to merge 1 commit into from

Conversation

cbuescher
Copy link
Member

The parameter exists in the indices.get API already, they both map to the same
REST action. Although the response body for the HEAD request used for checking
existence is empty, the parameter can be used to avoid deprecation warnings and
should be added so clients that generate their API from the rest spec pick it
up.

Closes #43905

The parameter exists in the indices.get API already, they both map to the same
REST action. Although the response body for the HEAD request used for checking
existence is empty, the parameter can be used to avoid deprecation warnings and
should be added so clients that generate their API from the rest spec pick it
up.

Closes elastic#43905
@cbuescher cbuescher added >bug :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0 v7.3.0 v6.8.2 v7.2.1 labels Jul 3, 2019
@cbuescher cbuescher requested a review from jtibshirani July 3, 2019 11:09
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@jpountz jpountz added v7.4.0 and removed v7.3.0 labels Jul 3, 2019
@jtibshirani
Copy link
Contributor

jtibshirani commented Jul 4, 2019

@cbuescher thanks for tackling this bug! My sense is that we should actually remove the deprecation warning for indices.exist requests, since it has no possibility of returning a type. In particular, we could check if request.method().equals(HEAD) and avoid emitting a deprecating warning in that case. I think it might be confusing for a user to have to add include_type_name to a request where there are no types in the request/ response.

@cbuescher
Copy link
Member Author

we should actually remove the deprecation warning for indices.exist requests

Thanks for the feedback, that was another solution I briefly thought about. Will update the PR accordingly.

@cbuescher
Copy link
Member Author

@jtibshirani I opened #43963 in stead of this one to remove the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Search Foundations/Mapping Index mappings, including merging and defining field types v6.8.2 v7.2.1 v7.4.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indices Exists API missing include_type_name in REST API spec
5 participants