SmokeTestWatcherWithSecurityIT: Retry if failures searching .watcher-history #43781
Conversation
…history Catch exceptions and fail (which allows the assertBusy to retry) if an error happens from the search against .watcher-history. Related: elastic#42409 Related: elastic#39169
|
Pinging @elastic/es-core-features |
|
I should note this is the same change that was applied to the non-security variant: https://github.com/elastic/elasticsearch/blob/master/x-pack/qa/smoke-test-watcher/src/test/java/org/elasticsearch/smoketest/SmokeTestWatcherTestSuiteIT.java#L218 |
| @@ -330,6 +331,10 @@ private ObjectPath getWatchHistoryEntry(String watchId, String state) throws Exc | |||
| String watchid = objectPath.evaluate("hits.hits.0._source.watch_id"); | |||
| assertThat(watchid, is(watchId)); | |||
| objectPathReference.set(objectPath); | |||
| } catch (ResponseException e) { | |||
| final String err = "Failed to perform search of watcher history - " + e; | |||
| logger.info(err); | |||
There was a problem hiding this comment.
Any particular reason not to use
| logger.info(err); | |
| logger.info("Failed to perform search of watcher history", e); |
Here instead so that you get the whole stacktrace?
|
@elasticmachine update branch |
…43781) Retry if failures searching .watcher-history Catch exceptions and fail (which allows the assertBusy to retry) if an error happens from the search against .watcher-history. Related: elastic#42409 Related: elastic#39169
|
holding off on backporting since this test is currently muted in the older pipelines. Trying to stabilize this test in master before backporting. |
|
@jakelandis I bumped the version since this hasn't been backported yet. |
|
I am trying to stabilize these tests in master before backporting. I will remove the backport versions and track this via the meta issue #42409 |
jakelandis
added
v8.0.0-alpha1
>test
Catch exception and fail (which allows the assertBusy to retry)
if an error happens from the search against .watcher-history.
Related: #42409
Related: #39169