Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Clarify refresh_interval new behavior #43726

Merged
merged 2 commits into from
Jul 15, 2019
Merged

Conversation

tbuchier
Copy link
Contributor

Update indexing-speed.asciidoc to clarify refresh_interval new behavior

Close #43724

Finally I tried to write the explanation myself, maybe it can be more concise.

Thanks

Update indexing-speed.asciidoc to clarify refresh_interval new behavior
@dliappis dliappis added the :Core/Infra/Core Core issues without another label label Jun 28, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@dliappis dliappis added the >docs General docs changes label Jun 28, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@dliappis dliappis requested a review from jpountz June 28, 2019 10:14
@dliappis
Copy link
Contributor

@jpountz I asked you for a review as you've worked on the docs here. AFAIU from the commit description in #27500 indeed, setting refresh_interval explicitly to any value (even 1s) will disable the "search idle" behavior.

@tbuchier
Copy link
Contributor Author

I changed the text in the second commit to re-use what's written here :

https://www.elastic.co/guide/en/elasticsearch/reference/current/index-modules.html#dynamic-index-settings

I found this page afterwards, and it explain contain the new behavior explanation :)

Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is correct. If this clarifies it for you, then I'm +1 on merging this.

@javanna
Copy link
Member

javanna commented Jul 15, 2019

test this please

@javanna javanna merged commit 0fb2f69 into elastic:master Jul 15, 2019
@jpountz jpountz added v7.3.0 and removed v7.3.1 labels Jul 15, 2019
javanna pushed a commit that referenced this pull request Jul 16, 2019
Update indexing-speed.asciidoc to clarify refresh_interval new behavior
javanna pushed a commit that referenced this pull request Jul 16, 2019
Update indexing-speed.asciidoc to clarify refresh_interval new behavior
javanna pushed a commit that referenced this pull request Jul 16, 2019
Update indexing-speed.asciidoc to clarify refresh_interval new behavior
javanna pushed a commit that referenced this pull request Jul 16, 2019
Update indexing-speed.asciidoc to clarify refresh_interval new behavior
javanna pushed a commit that referenced this pull request Jul 16, 2019
Update indexing-speed.asciidoc to clarify refresh_interval new behavior
@jakelandis jakelandis removed the v8.0.0 label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] refresh_interval change made it unclear
6 participants