Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML][Data Frame] removing format support in date_histogram group_by #43659

Merged

Conversation

benwtrent
Copy link
Member

@benwtrent benwtrent commented Jun 26, 2019

Removes the format support from the date_histogram group by. Verifying all references are removed.

The submission of a format field should be removed from kibana before this PR is merged.

Related to: elastic/kibana#39250

Blocked by: elastic/kibana#39811

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@benwtrent benwtrent changed the title [ML][Data Frame] removing format support [ML][Data Frame] removing format support in date_histogram group_by Jun 26, 2019
@benwtrent
Copy link
Member Author

run elasticsearch-ci/1

@benwtrent benwtrent marked this pull request as ready for review June 28, 2019 11:47
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent merged commit d1ff981 into elastic:master Jun 28, 2019
@benwtrent benwtrent deleted the feature/ml-df-remove-support-for-format branch June 28, 2019 13:09
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Jun 28, 2019
benwtrent added a commit that referenced this pull request Jun 28, 2019
* [ML][Data Frame] removing format support (#43659)

* Fixing conflicts
@jpountz
Copy link
Contributor

jpountz commented Jul 26, 2019

@benwtrent Since this is a breaking change, could you add a mention to it in the 7.3 migration guide?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants