Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix intervals source #43635

Merged
merged 4 commits into from
Jun 26, 2019
Merged

Conversation

romseygeek
Copy link
Contributor

This commit adds a prefix intervals source, allowing you to search
for intervals that contain terms starting with a given prefix. The source
can make use of the index_prefixes mapping option.

Relates to #43198

@romseygeek romseygeek added >feature :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.3.0 labels Jun 26, 2019
@romseygeek romseygeek requested a review from jimczi June 26, 2019 11:45
@romseygeek romseygeek self-assigned this Jun 26, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a small comment regarding the docs, LGTM otherwise

`use_field`::
If specified, then match intervals from this field rather than the top-level field.
The `prefix` will be normalized using the search analyzer from this field, unless
`analyzer` is specified separately.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a note regarding the index_prefixes option of the text field since some queries will fail if they expand to more than 128 terms ?

@romseygeek romseygeek merged commit a520a5d into elastic:master Jun 26, 2019
romseygeek added a commit that referenced this pull request Jun 26, 2019
This commit adds a prefix intervals source, allowing you to search
for intervals that contain terms starting with a given prefix. The source
can make use of the index_prefixes mapping option.

Relates to #43198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>feature :Search/Search Search-related issues that do not fall into other categories v7.3.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants