Add GeometryTree support for point/multipoint #43432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talevy
added
the
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo |
|
run elasticsearch-ci/2 |
This commit adds support for MultiPoint and Point shapes to be stored in GeometryTree. To represent the collection of points, a KDbush is used, which is a sorted array sorted recursively by alternating dimensions x/y. This work is inspired by https://github.com/mourner/kdbush The purpose of this reader is to check whether any subset of the points in the kd-tree are contained within the bounding-box query.
imotov
reviewed
Jun 21, 2019
server/src/main/java/org/elasticsearch/common/geo/Point2DWriter.java
Outdated
Show resolved
Hide resolved
libs/geo/src/main/java/org/elasticsearch/geo/geometry/MultiPoint.java
Outdated
Show resolved
Hide resolved
libs/geo/src/main/java/org/elasticsearch/geo/geometry/GeometryCollection.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/common/geo/GeometryTreeReader.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/common/geo/GeometryTreeWriter.java
Outdated
Show resolved
Hide resolved
|
thanks @imotov, I've tried to respond to all your good comments! |
imotov
approved these changes
Jun 21, 2019
server/src/main/java/org/elasticsearch/common/geo/Point2DWriter.java
Outdated
Show resolved
Hide resolved
|
thanks Igor! |
talevy
added a commit
that referenced
this pull request
Sep 20, 2019
* Add GeometryTree support for point/multipoint This commit adds support for MultiPoint and Point shapes to be stored in GeometryTree. To represent the collection of points, a KDbush is used, which is a sorted array sorted recursively by alternating dimensions x/y. This work is inspired by https://github.com/mourner/kdbush The purpose of this reader is to check whether any subset of the points in the kd-tree are contained within the bounding-box query. * unify reader interface and cleanup multipoint usage * respond to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for MultiPoint and Point
shapes to be stored in GeometryTree.
To represent the collection of points, a KDbush is used, which is
a sorted array sorted recursively by alternating dimensions x/y.
This work is inspired by https://github.com/mourner/kdbush
The purpose of this reader is to check whether any subset of the
points in the kd-tree are contained within the bounding-box query.