Allow reloading of search time analyzers #43313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 14, 2019 17:29
Currently changing resources (like dictionaries, synonym files etc...) of search time analyzers is only possible by closing an index, changing the underlying resource (e.g. synonym files) and then re-opening the index for the change to take effect. This PR adds a new API endpoint that allows triggering reloading of certain analysis resources (currently token filters) that will then pick up changes in underlying file resources. To achieve this we introduce a new type of custom analyzer (ReloadableCustomAnalyzer) that uses a ReuseStrategy that allows swapping out analysis components. Custom analyzers that contain filters that are markes as "updateable" will automatically choose this implementation. This PR also adds this capability to `synonym` token filters for use in search time analyzers. Relates to elastic#29051
cbuescher
added
>enhancement
:Search Relevance/Analysis
|
Pinging @elastic/es-search |
jpountz
approved these changes
Jun 18, 2019
rest-api-spec/src/main/resources/rest-api-spec/api/indices.reload_search_analyzers.json
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/analysis/ReloadableCustomAnalyzer.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/analysis/ReloadableCustomAnalyzer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/analysis/ReloadableCustomAnalyzer.java
Outdated
Show resolved
Hide resolved
added 3 commits
June 25, 2019 10:31
The new "updateable" flag used with synonym and synonym_graph should be mentioned with the reload API endpoint which I also moved under the x-pack basic role with this change.
|
@jpountz I addressed your comments on this PR, also merged in a couple of other changes to the docs and moved the endpoint to xpack (both reviewed in #43536, #43559). Maybe you want to take another last look, the only thing I left like it was is allowing the GET/POST methods on the enpoint, but I'm happy to change that if you think its better. Let me know if I should change anything else, otherwise I'll try to get a green CI build before merging. |
cbuescher
force-pushed
the
reloadable-analyzers-feature
branch
from
d1eedf9 to
fca53c5
Compare
|
@elasticmachine run elasticsearch-ci/2 |
cbuescher
changed the title
|
Talked to @jpountz and its okay to merge. If there are any changes that need to be done after the fact we can still get them in in a separate PR. |
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Jun 27, 2019
Currently changing resources (like dictionaries, synonym files etc...) of search time analyzers is only possible by closing an index, changing the underlying resource (e.g. synonym files) and then re-opening the index for the change to take effect. This PR adds a new API endpoint that allows triggering reloading of certain analysis resources (currently token filters) that will then pick up changes in underlying file resources. To achieve this we introduce a new type of custom analyzer (ReloadableCustomAnalyzer) that uses a ReuseStrategy that allows swapping out analysis components. Custom analyzers that contain filters that are markes as "updateable" will automatically choose this implementation. This PR also adds this capability to `synonym` token filters for use in search time analyzers. Relates to elastic#29051
cbuescher
pushed a commit
that referenced
this pull request
Jun 28, 2019
Currently changing resources (like dictionaries, synonym files etc...) of search time analyzers is only possible by closing an index, changing the underlying resource (e.g. synonym files) and then re-opening the index for the change to take effect. This PR adds a new API endpoint that allows triggering reloading of certain analysis resources (currently token filters) that will then pick up changes in underlying file resources. To achieve this we introduce a new type of custom analyzer (ReloadableCustomAnalyzer) that uses a ReuseStrategy that allows swapping out analysis components. Custom analyzers that contain filters that are markes as "updateable" will automatically choose this implementation. This PR also adds this capability to `synonym` token filters for use in search time analyzers. Relates to #29051
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Jun 28, 2019
This change adds the new endpoint that allows reloading of search analyzers to the high-level java rest client. Relates to elastic#43313
cbuescher
pushed a commit
that referenced
this pull request
Jul 3, 2019
This change adds the new endpoint that allows reloading of search analyzers to the high-level java rest client. Relates to #43313
cbuescher
pushed a commit
that referenced
this pull request
Jul 3, 2019
This change adds the new endpoint that allows reloading of search analyzers to the high-level java rest client. Relates to #43313
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently changing resources (like dictionaries, synonym files etc...) of search
time analyzers is only possible by closing an index, changing the underlying
resource (e.g. synonym files) and then re-opening the index for the change to
take effect.
This PR adds a new API endpoint that allows triggering reloading of certain
analysis resources (currently token filters) that will then pick up changes in
underlying file resources. To achieve this we introduce a new type of custom
analyzer (ReloadableCustomAnalyzer) that uses a ReuseStrategy that allows
swapping out analysis components. Custom analyzers that contain filters that are
markes as "updateable" will automatically choose this implementation. This PR
also adds this capability to synonym token filters for use in search time
analyzers.
Relates to #29051