Move query builder caching check to dedicated tests #43238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `AbstractQueryTestCase#testToQuery` checks the search context cachable flag. This is a bit fragile due to the high randomization of query builders performed by this general test. Also we might only rarely check the "interesting" cases because they rarely get generated when fully randomizing the query builder. This change moved the general checks out ot #testToQuery and instead adds dedicated cache tests for those query builders that exhibit something other than the default behaviour. Closes elastic#43200
cbuescher
added
>test
|
Pinging @elastic/es-search |
jimczi
reviewed
Jun 17, 2019
server/src/test/java/org/elasticsearch/index/query/MoreLikeThisQueryBuilderTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/query/TermsSetQueryBuilderTests.java
Show resolved
Hide resolved
|
@jimczi thanks, added the two requested tests |
|
@elasticmachine run elasticsearch-ci/bwc |
|
@jimczi I also added the dedicated test for range queries that you requested, this should be ready for another review now. |
|
@elasticmachine update branch |
jimczi
approved these changes
Jun 27, 2019
server/src/test/java/org/elasticsearch/index/query/RangeQueryBuilderTests.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine run elasticsearch-ci/default-distro |
cbuescher
pushed a commit
that referenced
this pull request
Jun 27, 2019
Currently `AbstractQueryTestCase#testToQuery` checks the search context cachable flag. This is a bit fragile due to the high randomization of query builders performed by this general test. Also we might only rarely check the "interesting" cases because they rarely get generated when fully randomizing the query builder. This change moved the general checks out ot #testToQuery and instead adds dedicated cache tests for those query builders that exhibit something other than the default behaviour. Closes #43200
|
Thanks Jim, merged to master and 7.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
AbstractQueryTestCase#testToQuerychecks the search context cachableflag. This is a bit fragile due to the high randomization of query builders
performed by this general test. Also we might only rarely check the
"interesting" cases because they rarely get generated when fully randomizing the
query builder.
This change moved the general checks out ot #testToQuery and instead adds
dedicated cache tests for those query builders that exhibit something other than
the default behaviour.
Closes #43200