Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make GeometryTree and EdgeTree writers implement Writeable #42910

Merged
merged 2 commits into from
Jun 7, 2019

Conversation

talevy
Copy link
Contributor

@talevy talevy commented Jun 5, 2019

to simplify the writing interface of the tree writers, this PR
abstracts away the use of BytesRef creation in those cases.

@talevy talevy added the :Analytics/Geo Indexing, search aggregations of geo points and shapes label Jun 5, 2019
@talevy talevy requested a review from imotov June 5, 2019 23:29
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

@talevy
Copy link
Contributor Author

talevy commented Jun 6, 2019

run elasticsearch-ci/bwc
run elasticsearch-ci/default-distro

Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good start for the refactoring that we discussed.

@talevy talevy merged commit 49975f2 into elastic:geoshape-doc-values Jun 7, 2019
@talevy talevy deleted the writeable-geometry branch June 7, 2019 20:25
@talevy
Copy link
Contributor Author

talevy commented Jun 7, 2019

thanks Igor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants