Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Class Load Order in Netty4Plugin (#42591) #42703

Merged
merged 1 commit into from
May 30, 2019
Merged

Fix Class Load Order in Netty4Plugin (#42591) #42703

merged 1 commit into from
May 30, 2019

Conversation

original-brownbear
Copy link
Member

  • Don't force the logger in the Netty4Plugin class already, at this point log4j might not be fully initialized.
    • The call was redundant anyway since we do the same thing in the Netty4Transport and Netty4HttpServerTransport classes already and there we do it properly after setting up log4j by initilizing the loggers
  • Relates NoClassDefFoundError: io/netty/util/concurrent/PromiseTask #42532

@original-brownbear
Fix Class Load Order in Netty4Plugin (elastic#42591)
a3e089c 
* Don't force the logger in the Netty4Plugin class already, at this point log4j might not be fully initialized.
   * The call was redundant anyway since we do the same thing in the Netty4Transport and Netty4HttpServerTransport classes already and there we do it properly after setting up log4j by initilizing the loggers
* Relates elastic#42532
@original-brownbear original-brownbear merged commit 47d50c6 into elastic:7.x May 30, 2019
@original-brownbear original-brownbear deleted the 42591-7.x branch May 30, 2019 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@original-brownbear