Use reproducible method of generating properties file for better caching #42539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra |
rjernst
reviewed
May 24, 2019
| processResources { | ||
| inputs.file(propsFile) | ||
| // We need to be explicit with the version because we add snapshot and qualifier to it based on properties | ||
| inputs.property("dynamic_elasticsearch_version", props.getProperty("elasticsearch")) |
There was a problem hiding this comment.
It seems we lost adding this property?
There was a problem hiding this comment.
It's no longer necessary as the generate task tracks all properties as an input.
properties(props) // final computed prop values are an input to generateVersionProperties task```
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default Java implementation of
Properties.store()is non-reproducible. First, because it stores properties internally in aHashTableso the final ordering will be non-deterministic and secondly because it injects a comment with a timestamp into the generated file. Both of these things break build cacheability since this file eventually ends up on the build classpath.Here we use Gradle's
WritePropertiestask instead which solves both issues and ensures for the same set on inputs, reproducible output will be generated.