Cluster state from API should always have a master #42454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today the `TransportClusterStateAction` ignores the state passed by the `TransportMasterNodeAction` and obtains its state from the cluster applier. This might be inconsistent, showing a different node as the master or maybe even having no master. This change adjusts the action to use the passed-in state directly, and adds tests showing that the state returned is consistent with our expectations even if there is a concurrent master failover. Fixes elastic#38331 Relates elastic#38432
DaveCTurner
added
>bug
:Distributed Coordination/Cluster Coordination
|
Pinging @elastic/es-distributed |
martijnvg
approved these changes
May 24, 2019
| @Override | ||
| public void onClusterServiceClose() { | ||
| listener.onFailure(new NodeClosedException(clusterService.localNode())); | ||
| if (acceptableClusterStatePredicate.test(state)) { |
DaveCTurner
deleted the
2019-05-23-get-cluster-state-always-returns-master
branch
DaveCTurner
added a commit
that referenced
this pull request
May 24, 2019
Today the `TransportClusterStateAction` ignores the state passed by the `TransportMasterNodeAction` and obtains its state from the cluster applier. This might be inconsistent, showing a different node as the master or maybe even having no master. This change adjusts the action to use the passed-in state directly, and adds tests showing that the state returned is consistent with our expectations even if there is a concurrent master failover. Fixes #38331 Relates #38432
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Today the `TransportClusterStateAction` ignores the state passed by the `TransportMasterNodeAction` and obtains its state from the cluster applier. This might be inconsistent, showing a different node as the master or maybe even having no master. This change adjusts the action to use the passed-in state directly, and adds tests showing that the state returned is consistent with our expectations even if there is a concurrent master failover. Fixes elastic#38331 Relates elastic#38432
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Jul 16, 2019
The underlying issue is closed and the fix in elastic#42454 seems to have been backported to 7.x and 7.3 so we can reactivate the test.
cbuescher
pushed a commit
that referenced
this pull request
Jul 16, 2019
The underlying issue is closed and the fix in #42454 seems to have been backported to 7.x and 7.3 so we can reactivate the test.
cbuescher
pushed a commit
that referenced
this pull request
Jul 16, 2019
The underlying issue is closed and the fix in #42454 seems to have been backported to 7.x and 7.3 so we can reactivate the test.
DaveCTurner
added a commit
that referenced
this pull request
Jul 17, 2019
Today the `TransportClusterStateAction` ignores the state passed by the `TransportMasterNodeAction` and obtains its state from the cluster applier. This might be inconsistent, showing a different node as the master or maybe even having no master. This change adjusts the action to use the passed-in state directly, and adds tests showing that the state returned is consistent with our expectations even if there is a concurrent master failover. Fixes #38331 Relates #38432
|
Backported to 7.2 as 52e8a64 (and unmuted the associated test) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the
TransportClusterStateActionignores the state passed by theTransportMasterNodeActionand obtains its state from the cluster applier.This might be inconsistent, showing a different node as the master or maybe
even having no master.
This change adjusts the action to use the passed-in state directly, and adds
tests showing that the state returned is consistent with our expectations even
if there is a concurrent master failover.
Fixes #38331
Relates #38432